Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency Slider in Context Menu (with typo fix) #234

Merged
merged 12 commits into from
Feb 3, 2024

Conversation

dbzfanatic
Copy link
Contributor

I've added a custom class for a slider to be in the context menu so the opacity can still be adjusted even if MainForm isn't showing properly. I also fixed a typo in the .iss file where the regkey was created as "First Run" instead of "FirstRun".

@mscrivo
Copy link
Owner

mscrivo commented Jan 12, 2024

Thanks for the contribution! I'll check this out as soon as I get a spare moment

@mscrivo
Copy link
Owner

mscrivo commented Jan 14, 2024

This is a great start! There's a couple things I think wee need to resolve before this can go in:

  1. The styling of the transparency menu is off. Let's see if there's any way we can make it a little more sleek and take up the whole width of the menu:
    image
  2. Second, files should not be added explicitly to the Ootd.x86 and Ootd.x64 projects. Those are essentially mirrors of what's in the Ootd.Core project. All changes should be made there and then the files you add should be linked to the x86/x64 project.

Let me know if you're willing to do this, otherwise I can take a stab at it.

@dbzfanatic
Copy link
Contributor Author

dbzfanatic commented Jan 15, 2024

  1. I can get it to be wider without issue but no matter what I tried I can't get it be any smaller in height. I suppose it's possible to use the MACTrackBar but I'm not familiar with that control so it would require some learning and retooling.

  2. I only added the files explicitly to the x** versions because for some reason I could not get the reference to add from Core. It's possibly an error on my part or perhaps my install is borked but that was more of a bandaid fix to get it to work. Once I figure out what's going on with the reference(s) this should be an easy one to fix.

Edit: I'm pretty sure I was hitting "Add" instead of "Add as Link" so...probably shouldn't make a commit when I'm brain fried lol.

Fixed Typo in FirstRun regkey

(cherry picked from commit 1009c12)
@dbzfanatic
Copy link
Contributor Author

dbzfanatic commented Feb 1, 2024

image

I swapped over to using MACTrackBar in a simplistic manner since it's in the context menu. It seems that even with a Margin of 0 a certain portion of the menu is reserved for the expansion arrow for sub-menus and, as far as I've found, there's no real way to bypass that easily.

Edit: Seems like there are some "code check" errors but it builds and runs fine. My guess is it's because it's using intellisense and trying to parse things from the MACTrackBarLib and can't. I verified manually that everything it's complaining about is defined and they are.

Edit 2: Re-adding the references to x86 and x64 seems to have done the trick. Weird, but at least it was an easy fix.

dbzfanatic and others added 7 commits February 2, 2024 09:25
(cherry picked from commit 5d5dd49)
Had to fix resources generation with new Visual Studio

(cherry picked from commit 41f7ccd)
(cherry picked from commit f794921)
(cherry picked from commit bddfb9b)
@mscrivo
Copy link
Owner

mscrivo commented Feb 3, 2024

This looks great, thank you for the contribution! I've made some small modifications to tidy it up a bit. I'll merge it in and try to get a release out asap.

@mscrivo mscrivo merged commit 4e928b0 into mscrivo:main Feb 3, 2024
2 checks passed
@mscrivo
Copy link
Owner

mscrivo commented Feb 4, 2024

You can try a build with your changes here: https://mscrivo.visualstudio.com/d1e953c0-d0ad-48e7-b6e1-a401a9b831f3/_apis/build/builds/450/artifacts?artifactName=artifact&api-version=7.1&%24format=zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants