-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparency Slider in Context Menu (with typo fix) #234
Conversation
Fixed Typo in FirstRun regkey
Thanks for the contribution! I'll check this out as soon as I get a spare moment |
Edit: I'm pretty sure I was hitting "Add" instead of "Add as Link" so...probably shouldn't make a commit when I'm brain fried lol. |
Fixed Typo in FirstRun regkey (cherry picked from commit 1009c12)
I swapped over to using MACTrackBar in a simplistic manner since it's in the context menu. It seems that even with a Margin of 0 a certain portion of the menu is reserved for the expansion arrow for sub-menus and, as far as I've found, there's no real way to bypass that easily. Edit: Seems like there are some "code check" errors but it builds and runs fine. My guess is it's because it's using intellisense and trying to parse things from the MACTrackBarLib and can't. I verified manually that everything it's complaining about is defined and they are. Edit 2: Re-adding the references to x86 and x64 seems to have done the trick. Weird, but at least it was an easy fix. |
This looks great, thank you for the contribution! I've made some small modifications to tidy it up a bit. I'll merge it in and try to get a release out asap. |
You can try a build with your changes here: https://mscrivo.visualstudio.com/d1e953c0-d0ad-48e7-b6e1-a401a9b831f3/_apis/build/builds/450/artifacts?artifactName=artifact&api-version=7.1&%24format=zip |
I've added a custom class for a slider to be in the context menu so the opacity can still be adjusted even if MainForm isn't showing properly. I also fixed a typo in the .iss file where the regkey was created as "First Run" instead of "FirstRun".